Bug 30154 – Allow custom memory allocation control for JavaScriptCore's SharedSymbolTable

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Template Framework

[Zoltan Horvath]

Inherits SharedSymbolTable struct from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:621.

[Zoltan Horvath]

Created attachment 40767 [details]
proposed patch

[Zoltan Horvath]

I've mixed up SharedSymbolTable with SymbolTableEntry. SharedSymbolTable is inherited from RefCounted also, so doesn't need to be inherited. 

I mark this invalid and r-.

[Zoltan Horvath]

Comment on attachment 40767 [details]
proposed patch

> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 49225)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> [phone]  Zoltan Horvath  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Allow custom memory allocation control for JavaScriptCore's SharedSymbolTable
> +        https://bugs.webkit.org/show_bug.cgi?id=30154
> +
> +        Inherits SharedSymbolTable struct from FastAllocBase because it
> +        has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:621.
> +
> +        * runtime/SymbolTable.h:
> +
>  2009-10-06  Priit Laes  <[e-mail]>
>  
>          Reviewed by Gavin Barraclough.
> Index: JavaScriptCore/runtime/SymbolTable.h
> ===================================================================
> --- JavaScriptCore/runtime/SymbolTable.h	(revision 49225)
> +++ JavaScriptCore/runtime/SymbolTable.h	(working copy)
> @@ -41,7 +41,7 @@ namespace JSC {
>      // reasonably small positive or negative number, and therefore has its high
>      // four bits all set or all unset.
>  
> -    struct SymbolTableEntry {
> +    struct SymbolTableEntry : FastAllocBase {
>          SymbolTableEntry()
>              : m_bits(0)
>          {