Bug 30154 - Allow custom memory allocation control for JavaScriptCore's SharedSymbolTable
Summary: Allow custom memory allocation control for JavaScriptCore's SharedSymbolTable
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 00:16 PDT by Zoltan Horvath
Modified: 2009-10-07 09:55 PDT (History)
0 users

See Also:


Attachments
proposed patch (1.22 KB, patch)
2009-10-07 00:23 PDT, Zoltan Horvath
zoltan: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-10-07 00:16:23 PDT
Inherits SharedSymbolTable struct from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:621.
Comment 1 Zoltan Horvath 2009-10-07 00:23:38 PDT
Created attachment 40767 [details]
proposed patch
Comment 2 Zoltan Horvath 2009-10-07 09:54:52 PDT
I've mixed up SharedSymbolTable with SymbolTableEntry. SharedSymbolTable is inherited from RefCounted also, so doesn't need to be inherited. 

I mark this invalid and r-.
Comment 3 Zoltan Horvath 2009-10-07 09:55:12 PDT
Comment on attachment 40767 [details]
proposed patch

> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 49225)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2009-10-07  Zoltan Horvath  <zoltan@webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Allow custom memory allocation control for JavaScriptCore's SharedSymbolTable
> +        https://bugs.webkit.org/show_bug.cgi?id=30154
> +
> +        Inherits SharedSymbolTable struct from FastAllocBase because it
> +        has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:621.
> +
> +        * runtime/SymbolTable.h:
> +
>  2009-10-06  Priit Laes  <plaes@plaes.org>
>  
>          Reviewed by Gavin Barraclough.
> Index: JavaScriptCore/runtime/SymbolTable.h
> ===================================================================
> --- JavaScriptCore/runtime/SymbolTable.h	(revision 49225)
> +++ JavaScriptCore/runtime/SymbolTable.h	(working copy)
> @@ -41,7 +41,7 @@ namespace JSC {
>      // reasonably small positive or negative number, and therefore has its high
>      // four bits all set or all unset.
>  
> -    struct SymbolTableEntry {
> +    struct SymbolTableEntry : FastAllocBase {
>          SymbolTableEntry()
>              : m_bits(0)
>          {