Bug 30108 - accessibility/media-element.html crashes
: accessibility/media-element.html crashes
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Media Elements
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Simon Fraser (smfr)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-05 21:48 PDT by Simon Fraser (smfr)
Modified: 2009-10-06 21:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.21 KB, patch)
2009-10-06 13:30 PDT, Simon Fraser (smfr)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-10-05 21:48:50 PDT
Crash here:

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   com.apple.WebKit              	0x000000010077eae7 -[WebViewFactory localizedMediaControlElementString:] + 1120 (WebViewFactory.mm:683)
1   com.apple.WebCore             	0x0000000101235a30 WebCore::localizedMediaControlElementString(WebCore::String const&) + 79 (LocalizedStringsMac.mm:729)
2   com.apple.WebCore             	0x0000000100b525a2 WebCore::AccessibilityMediaControl::accessibilityDescription() const + 46 (AccessibilityMediaControls.cpp:159)
3   com.apple.WebCore             	0x0000000100b60ebf -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 4708 (AccessibilityObjectWrapper.mm:1357)
4   DumpRenderTree                	0x00000001000057cd AccessibilityUIElement::description() + 49 (AccessibilityUIElementMac.mm:328)

Need to add strings for the fullscreen button.
Comment 1 Simon Fraser (smfr) 2009-10-06 13:30:04 PDT
Created attachment 40739 [details]
Patch
Comment 2 Mark Rowe (bdash) 2009-10-06 13:42:30 PDT
Comment on attachment 40739 [details]
Patch

I made some minor comments on IRC.  r=me
Comment 3 Simon Fraser (smfr) 2009-10-06 21:33:15 PDT
http://trac.webkit.org/changeset/49206