Bug 30106 – Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Hin-Chung Lam]

MediaPlayer and MediaPlayerPrivateInterface has some dead methods that are unrelated to the spec:

setRate(float)
float dataRate()
setEndTime(float)

etc..

These classes need to be cleaned up to match the spec.

[Eric Carlson]

Created attachment 47077 [details]
Proposed patch

[Eric Carlson]

http://trac.webkit.org/changeset/53625

[Csaba Osztrogonác]

This patch broke Qt build, because it removed totalBytesKnown(), but WebCore/platform/qt/RenderThemeQt.cpp used it. totalBytesKnown() always returned false, so it was really unreachable code, but it can be useful in the future.

error message: ( http://build.webkit.org/builders/Qt%20Linux%20Release/builds/6325/steps/compile-webkit/logs/stdio )
/../../WebCore/platform/qt/RenderThemeQt.cpp:983: error: 'class WebCore::MediaPlayer' has no member named 'totalBytesKnown'
../../../WebCore/platform/qt/RenderThemeQt.cpp:984: error: 'class WebCore::MediaPlayer' has no member named 'totalBytes'

I committed a buildfix into http://trac.webkit.org/changeset/53632, but I'm not sure if we really want to remove this code introduced in http://trac.webkit.org/changeset/34300. Simon? Tor Arne?

[Eric Carlson]

Filed https://bugs.webkit.org/show_bug.cgi?id=33960 to restore totalBytesKnown and totalBytes methods.