Bug 30106 - Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods
Summary: Cleanup MediaPlayer and MediaPlayerPrivateInterface to remove dead methods
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Eric Carlson
Depends on:
Reported: 2009-10-05 21:40 PDT by Hin-Chung Lam
Modified: 2010-01-21 11:23 PST (History)
4 users (show)

See Also:

Proposed patch (15.06 KB, patch)
2010-01-20 16:46 PST, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hin-Chung Lam 2009-10-05 21:40:49 PDT
MediaPlayer and MediaPlayerPrivateInterface has some dead methods that are unrelated to the spec:

float dataRate()


These classes need to be cleaned up to match the spec.
Comment 1 Eric Carlson 2010-01-20 16:46:18 PST
Created attachment 47077 [details]
Proposed patch
Comment 2 Eric Carlson 2010-01-21 08:21:03 PST
Comment 3 Csaba Osztrogonác 2010-01-21 10:49:50 PST
This patch broke Qt build, because it removed totalBytesKnown(), but WebCore/platform/qt/RenderThemeQt.cpp used it. totalBytesKnown() always returned false, so it was really unreachable code, but it can be useful in the future.

error message: ( http://build.webkit.org/builders/Qt%20Linux%20Release/builds/6325/steps/compile-webkit/logs/stdio )
/../../WebCore/platform/qt/RenderThemeQt.cpp:983: error: 'class WebCore::MediaPlayer' has no member named 'totalBytesKnown'
../../../WebCore/platform/qt/RenderThemeQt.cpp:984: error: 'class WebCore::MediaPlayer' has no member named 'totalBytes'

I committed a buildfix into http://trac.webkit.org/changeset/53632, but I'm not sure if we really want to remove this code introduced in http://trac.webkit.org/changeset/34300. Simon? Tor Arne?
Comment 4 Eric Carlson 2010-01-21 11:23:07 PST
Filed https://bugs.webkit.org/show_bug.cgi?id=33960 to restore totalBytesKnown and totalBytes methods.