Bug 30076 - Header files of WebKitGTK do not comply with WebKit coding style (Patch attached)
Summary: Header files of WebKitGTK do not comply with WebKit coding style (Patch attac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-05 08:17 PDT by José Millán Soto
Modified: 2009-10-06 04:50 PDT (History)
1 user (show)

See Also:


Attachments
WebKitGtkHeaders.patch (11.55 KB, patch)
2009-10-05 08:17 PDT, José Millán Soto
xan.lopez: review-
Details | Formatted Diff | Diff
Patch (13.17 KB, patch)
2009-10-06 02:22 PDT, José Millán Soto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description José Millán Soto 2009-10-05 08:17:15 PDT
Created attachment 40633 [details]
WebKitGtkHeaders.patch

Header files located in WebKit/gtk do not comply with WebKit coding style,
as header guards should be named the same as the file wich they are guarding.

Moreover, DocumentLoaderGtk.h, does not even have header guard. This patch solves
this problem also.
Comment 1 Xan Lopez 2009-10-05 12:58:52 PDT
Comment on attachment 40633 [details]
WebKitGtkHeaders.patch

>-#ifndef WEBKIT_SOUP_AUTH_DIALOG_H
>-#define WEBKIT_SOUP_AUTH_DIALOG_H 1
>+#ifndef webkitsoupauthdialog_h
>+#define webkitsoupauthdialog_h 1

While we are at it, can we get rid of that '1' too?

You need to provide a ChangeLog as mentioned in the contributing document, using the prepare-ChangeLog script. Marking r- (also, you need to mark patches for review when attaching :))
Comment 2 José Millán Soto 2009-10-06 02:22:53 PDT
Created attachment 40704 [details]
Patch

Updated patch, wich solves problems of previous patch that were appointed in comment #1.
Comment 3 Xan Lopez 2009-10-06 02:24:53 PDT
Comment on attachment 40704 [details]
Patch

Looks good, thanks!
Comment 4 WebKit Commit Bot 2009-10-06 04:50:03 PDT
Comment on attachment 40704 [details]
Patch

Clearing flags on attachment: 40704

Committed r49168: <http://trac.webkit.org/changeset/49168>
Comment 5 WebKit Commit Bot 2009-10-06 04:50:06 PDT
All reviewed patches have been landed.  Closing bug.