Bug 29979 - chromium port features.gypi override mechanism
Summary: chromium port features.gypi override mechanism
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Yaar Schnitman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-01 13:48 PDT by Yaar Schnitman
Modified: 2009-10-01 15:21 PDT (History)
3 users (show)

See Also:

Attachments
patch (2.78 KB, patch)
2009-10-01 13:54 PDT, Yaar Schnitman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2009-10-01 13:48:20 PDT 
we want to be able to have different feature_defines when we build chromium webkit downstream (e.g. experimental features).
Comment 1 Yaar Schnitman 2009-10-01 13:54:27 PDT 
Created attachment 40474 [details]
patch

Patch doesn't depend on upcoming downstream change, so it won't break any builds.
Comment 2 Dimitri Glazkov (Google) 2009-10-01 14:04:23 PDT 
Comment on attachment 40474 [details]
patch

ok.
Comment 3 WebKit Commit Bot 2009-10-01 15:21:45 PDT 
Comment on attachment 40474 [details]
patch

Clearing flags on attachment: 40474

Committed r49002: <http://trac.webkit.org/changeset/49002>
Comment 4 WebKit Commit Bot 2009-10-01 15:21:49 PDT 
All reviewed patches have been landed.  Closing bug.