As above.
Created attachment 40456 [details] Implement the missing function
Created attachment 40458 [details] Remove fixed tests from the Skipped list
Created attachment 40459 [details] Implement the missing function The WebPage's constructor should call resetSettings().
Comment on attachment 40459 [details] Implement the missing function Great stuff, but I suggest to simplify the implmeneitation: Store the defaults in QWebSettings::globalSettings(), make overridePreferece() set the settings on the page's settings object and make resetSEttings() use resetAttribute, resetFontSize(), etc. to trigger the fallback to the global settings.
Created attachment 40523 [details] Implement the missing function (In reply to comment #4) > (From update of attachment 40459 [details]) > Great stuff, but I suggest to simplify the implmeneitation: > > Store the defaults in QWebSettings::globalSettings(), make overridePreferece() > set the settings on the page's settings object and make resetSEttings() use > resetAttribute, resetFontSize(), etc. to trigger the fallback to the global > settings. Sounds good, done.
Comment on attachment 40523 [details] Implement the missing function r=me, thanks!
Comment on attachment 40523 [details] Implement the missing function Clearing flags on attachment: 40523 Committed r49024: <http://trac.webkit.org/changeset/49024>
All reviewed patches have been landed. Closing bug.
Reopening since there's one patch to land.
Comment on attachment 40458 [details] Remove fixed tests from the Skipped list Clearing flags on attachment: 40458 Committed r49066: <http://trac.webkit.org/changeset/49066>