Bug 29970 - [Qt] Missing layoutTestController.overridePreference() implementation
Summary: [Qt] Missing layoutTestController.overridePreference() implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-01 10:18 PDT by Jakub Wieczorek
Modified: 2009-10-03 13:50 PDT (History)
2 users (show)

See Also:


Attachments
Implement the missing function (6.58 KB, patch)
2009-10-01 10:21 PDT, Jakub Wieczorek
no flags Details | Formatted Diff | Diff
Remove fixed tests from the Skipped list (1.95 KB, patch)
2009-10-01 10:24 PDT, Jakub Wieczorek
no flags Details | Formatted Diff | Diff
Implement the missing function (6.65 KB, patch)
2009-10-01 10:37 PDT, Jakub Wieczorek
hausmann: review-
Details | Formatted Diff | Diff
Implement the missing function (7.70 KB, patch)
2009-10-02 08:57 PDT, Jakub Wieczorek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Wieczorek 2009-10-01 10:18:36 PDT
As above.
Comment 1 Jakub Wieczorek 2009-10-01 10:21:51 PDT
Created attachment 40456 [details]
Implement the missing function
Comment 2 Jakub Wieczorek 2009-10-01 10:24:55 PDT
Created attachment 40458 [details]
Remove fixed tests from the Skipped list
Comment 3 Jakub Wieczorek 2009-10-01 10:37:12 PDT
Created attachment 40459 [details]
Implement the missing function

The WebPage's constructor should call resetSettings().
Comment 4 Simon Hausmann 2009-10-02 08:04:32 PDT
Comment on attachment 40459 [details]
Implement the missing function

Great stuff, but I suggest to simplify the implmeneitation:

Store the defaults in QWebSettings::globalSettings(), make overridePreferece() set the settings on the page's settings object and make resetSEttings() use resetAttribute, resetFontSize(), etc. to trigger the fallback to the global settings.
Comment 5 Jakub Wieczorek 2009-10-02 08:57:03 PDT
Created attachment 40523 [details]
Implement the missing function

(In reply to comment #4)
> (From update of attachment 40459 [details])
> Great stuff, but I suggest to simplify the implmeneitation:
> 
> Store the defaults in QWebSettings::globalSettings(), make overridePreferece()
> set the settings on the page's settings object and make resetSEttings() use
> resetAttribute, resetFontSize(), etc. to trigger the fallback to the global
> settings.

Sounds good, done.
Comment 6 Simon Hausmann 2009-10-02 09:03:07 PDT
Comment on attachment 40523 [details]
Implement the missing function

r=me, thanks!
Comment 7 WebKit Commit Bot 2009-10-02 09:14:57 PDT
Comment on attachment 40523 [details]
Implement the missing function

Clearing flags on attachment: 40523

Committed r49024: <http://trac.webkit.org/changeset/49024>
Comment 8 WebKit Commit Bot 2009-10-02 09:15:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Xan Lopez 2009-10-03 13:34:59 PDT
Reopening since there's one patch to land.
Comment 10 WebKit Commit Bot 2009-10-03 13:50:27 PDT
Comment on attachment 40458 [details]
Remove fixed tests from the Skipped list

Clearing flags on attachment: 40458

Committed r49066: <http://trac.webkit.org/changeset/49066>
Comment 11 WebKit Commit Bot 2009-10-03 13:50:31 PDT
All reviewed patches have been landed.  Closing bug.