WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29827
transforms/3d tests are not run in Release builds
https://bugs.webkit.org/show_bug.cgi?id=29827
Summary
transforms/3d tests are not run in Release builds
Eric Seidel (no email)
Reported
2009-09-28 15:03:03 PDT
transforms/3d tests are not run in Release builds WebCoreHas3DRendering is not an exported symbol, so the check in webkitdirs fails to find it:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitdirs.pm#L633
in Release builds of WebCore. We'll need to find a new way to check if we should run the transforms/3d tests or not. I only ran the tests in Release mode before checking in:
http://trac.webkit.org/changeset/48833
So the transforms/3d tests started failing in Debug mode on the bots:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/5406
Attachments
Patch
(3.69 KB, patch)
2009-09-30 13:15 PDT
,
Simon Fraser (smfr)
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2009-09-28 15:19:14 PDT
Nice find.
Simon Fraser (smfr)
Comment 2
2009-09-30 13:15:49 PDT
Created
attachment 40395
[details]
Patch
Mark Rowe (bdash)
Comment 3
2009-09-30 13:17:51 PDT
Comment on
attachment 40395
[details]
Patch r=me
Simon Fraser (smfr)
Comment 4
2009-09-30 13:20:01 PDT
http://trac.webkit.org/changeset/48945
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug