Bug 29827 - transforms/3d tests are not run in Release builds
Summary: transforms/3d tests are not run in Release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-28 15:03 PDT by Eric Seidel (no email)
Modified: 2009-09-30 13:20 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.69 KB, patch)
2009-09-30 13:15 PDT, Simon Fraser (smfr) 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-09-28 15:03:03 PDT 
transforms/3d tests are not run in Release builds

WebCoreHas3DRendering is not an exported symbol, so the check in webkitdirs fails to find it:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitdirs.pm#L633
in Release builds of WebCore.

We'll need to find a new way to check if we should run the transforms/3d tests or not.

I only ran the tests in Release mode before checking in:
http://trac.webkit.org/changeset/48833

So the transforms/3d tests started failing in Debug mode on the bots:
http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/5406
Comment 1 Simon Fraser (smfr) 2009-09-28 15:19:14 PDT 
Nice find.
Comment 2 Simon Fraser (smfr) 2009-09-30 13:15:49 PDT 
Created attachment 40395 [details]
Patch
Comment 3 Mark Rowe (bdash) 2009-09-30 13:17:51 PDT 
Comment on attachment 40395 [details]
Patch

r=me
Comment 4 Simon Fraser (smfr) 2009-09-30 13:20:01 PDT 
http://trac.webkit.org/changeset/48945