Bug 29788 - Web Inspector: Migrate database inspection to the injected script-based schema.
Summary: Web Inspector: Migrate database inspection to the injected script-based schema.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-27 10:58 PDT by Pavel Feldman
Modified: 2009-10-07 02:32 PDT (History)
2 users (show)

See Also:

Attachments
db (38.17 KB, patch)
2009-09-27 11:01 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-09-27 10:58:55 PDT 
This one is a bit different than the others since db transactions can't be executed synchronously on the injected script side.
Comment 1 Pavel Feldman 2009-09-27 11:01:16 PDT 
Created attachment 40203 [details]
db
Comment 2 Timothy Hatcher 2009-10-06 13:27:57 PDT 
Comment on attachment 40203 [details]
db

> +        errorCallback(null, "No database");

Is this string shown to the user? If so it should be a UIString.
Comment 3 Pavel Feldman 2009-10-07 02:32:35 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSInspectorBackendCustom.cpp
	M	WebCore/bindings/v8/custom/V8CustomBinding.h
	M	WebCore/bindings/v8/custom/V8InspectorBackendCustom.cpp
	M	WebCore/inspector/InspectorBackend.cpp
	M	WebCore/inspector/InspectorBackend.h
	M	WebCore/inspector/InspectorBackend.idl
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/InspectorController.h
	M	WebCore/inspector/InspectorDatabaseResource.cpp
	M	WebCore/inspector/InspectorDatabaseResource.h
	M	WebCore/inspector/InspectorFrontend.cpp
	M	WebCore/inspector/InspectorFrontend.h
	M	WebCore/inspector/front-end/Database.js
	M	WebCore/inspector/front-end/InjectedScript.js
	M	WebCore/inspector/front-end/InjectedScriptAccess.js
	M	WebCore/inspector/front-end/StoragePanel.js
	M	WebCore/inspector/front-end/inspector.js
Committed r49234