Bug 296208 – Problems with copyExternalImageToTexture

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

I've encountered two new problems in `copyExternalImageToTexture`:

1.- Is loading grayscale images such as: https://ludicon.com/sparkjs/assets/rocky_trail_rough_1k-DzyprOPd.png

It appears as if the grayscale image as interpreted as an alpha image blended against a pink background.

2.- Is loading svg files such as: 

https://ludicon.com/sparkjs/assets/Tiger-vZ19_T4F.svg

The svg image is not rendered.

You can easily reproduce these two issues in this website:

https://ludicon.com/sparkjs/

I've confirmed the two issues occur in the latest Safari Technology Preview in macOS. Chrome and Firefox handle these files correctly.

I hope these problems can be addressed before the OS 26 release!

[Mike Wyrzykowski]

Created attachment 476112 [details]
WebKit main 1st issue

[Mike Wyrzykowski]

Created attachment 476113 [details]
WebKit main 2nd issue

[Mike Wyrzykowski]

Attaching current behavior on WebKit main branch from iOS 

Possibly related to https://bugs.webkit.org/show_bug.cgi?id=295357

Will try on macOS next week

[Radar WebKit Bug Importer]

<rdar://problem/156219128>

[Mike Wyrzykowski]

I am unable to reproduce this locally on macOS, can you please verify if you reproduce on macOS Tahoe Beta 4?

[Mike Wyrzykowski]

or alternatively Safari Technology Preview 224 which should be a similar version of WebKit

I'm currently testing Safari Technology Preview 223. Let me try to upgrade.

Upgraded to 224 and the problem still persists. Note, the problem does not occur when loading the images normally, but when loading the referenced images as WebGPU textures through `copyExternalImageToTexture`. The problem can be reproduced easily through: 

https://ludicon.com/sparkjs/

The problematic images should appear in the gallery section and selecting them will display them in the WebGPU canvas. It should be possible to reproduce this issue with any other WebGPU example that uses the `copyExternalImageToTexture` API to load images.

[Mike Wyrzykowski]

Re-opening due to the above comment

[Mike Wyrzykowski]

Loading images via the gallery indeed exhibits some issues as opposed to directly opening the links

[Mike Wyrzykowski]

I no longer reproduce the rocky_trail_rough_1k-DzyprOPd.png issue on Safari Technology Preview 225 (WebKit 21623.1.1.1)

The SVG issue is still reproducible

[Mike Wyrzykowski]

The SVG doesn't load because we only support bitmaps currently:
```
        RefPtr image = dynamicDowncast<BitmapImage>(cachedImage->image());
        if (!image)
            return callback({ }, 0, 0);
```
cachedImage->image() is a WebCore::SVGImage

[Mike Wyrzykowski]

Created attachment 476416 [details]
SVG

Seems to fix it

[Mike Wyrzykowski]

Pull request: https://github.com/WebKit/WebKit/pull/49438

[EWS]

Committed 298758@main (e12b378f7885): <https://commits.webkit.org/298758@main>

Reviewed commits have been landed. Closing PR #49438 and removing active labels.

[Mike Wyrzykowski]

This should be fixed on webkit main now, I will followup once it lands in STP

Thanks for the quick turnaround!

[Mike Wyrzykowski]

Of course :) please let me know if you encounter any other incompatibilities!