Bug 29608 - Web Inspector: Exception formatting is broken in console
Summary: Web Inspector: Exception formatting is broken in console
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-21 13:28 PDT by Pavel Feldman
Modified: 2009-09-21 14:34 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.93 KB, patch)
2009-09-21 13:29 PDT, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-09-21 13:28:02 PDT 
1. Open WebInspector
2. Open console
3. Type "qwerty"

Expected: ReferenceError: Can't find variable: qwerty (in red)
Actual: nothing

This is a regression introduced by the "wrap primitive values" change. Now strings with error messages should also be wrapped.
Comment 1 Pavel Feldman 2009-09-21 13:29:55 PDT 
Created attachment 39868 [details]
patch
Comment 2 Pavel Feldman 2009-09-21 14:34:18 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ConsoleView.js
	M	WebCore/inspector/front-end/InjectedScript.js
Committed r48602