Bug 29253 - bugzilla-tool throws exception when run outside of a WebKit checkout
Summary: bugzilla-tool throws exception when run outside of a WebKit checkout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-14 13:59 PDT by Eric Seidel (no email)
Modified: 2009-10-21 10:25 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-09-14 13:59:48 PDT 
bugzilla-tool throws exception when run outside of a WebKit checkout

This is a regression.  Thankfully this will be easy to test once we fix it. :)

fatal: Not a git repository
Traceback (most recent call last):
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 946, in <module>
    main()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 942, in main
    tool = BugzillaTool()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 839, in __init__
    self.global_option_parser = HelpPrintingOptionParser(usage=self.usage_line(), formatter=NonWrappingEpilogIndentedHelpFormatter(), epilog=self.commands_usage())
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 867, in commands_usage
    scm_supports_local_commits = self.scm().supports_local_commits()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 846, in scm
    self.cached_scm = detect_scm_system(original_cwd)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/scm.py", line 43, in detect_scm_system
    if Git.in_working_directory(path):
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/scm.py", line 375, in in_working_directory
    return cls.run_command(['git', 'rev-parse', '--is-inside-work-tree'], cwd=path) == "true"
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/scm.py", line 113, in run_command
    raise ScriptError(args=args, exit_code=exit_code, output=output, cwd=cwd)
modules.scm.ScriptError: ('git', 'rev-parse', '--is-inside-work-tree')
Comment 1 Eric Seidel (no email) 2009-09-14 14:00:04 PDT 
The command I ran was "bugzilla-tool --help"
Comment 2 Eric Seidel (no email) 2009-10-21 10:25:58 PDT 
This was fixed a while ago.