Bug 29038 - Wrong preference name in layout tests
Summary: Wrong preference name in layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 10:17 PDT by Erik Arvidsson
Modified: 2009-09-09 09:44 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (1.59 KB, patch)
2009-09-08 14:30 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2009-09-08 10:17:39 PDT
The following layout tests

LayoutTests/fast/events/click-focus-anchor.html
LayoutTests/fast/events/tab-focus-anchor.html

Both contain a reference to a non-existing preference. The correct preference string is:

WebKitTabToLinksPreferenceKey
Comment 1 Erik Arvidsson 2009-09-08 14:30:37 PDT
Created attachment 39216 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2009-09-08 17:38:55 PDT
Comment on attachment 39216 [details]
Patch v1

Rejecting patch 39216 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 3 Eric Seidel (no email) 2009-09-09 09:33:35 PDT
media/video-source-error.html -> timed out
Yet another flakey media test.  I think I might add that one to the skipped list as yet another straw in the dam.  bug 28624.
Comment 4 Eric Seidel (no email) 2009-09-09 09:44:52 PDT
Comment on attachment 39216 [details]
Patch v1

Clearing flags on attachment: 39216

Committed r48211: <http://trac.webkit.org/changeset/48211>
Comment 5 Eric Seidel (no email) 2009-09-09 09:44:55 PDT
All reviewed patches have been landed.  Closing bug.