WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29038
Wrong preference name in layout tests
https://bugs.webkit.org/show_bug.cgi?id=29038
Summary
Wrong preference name in layout tests
Erik Arvidsson
Reported
2009-09-08 10:17:39 PDT
The following layout tests LayoutTests/fast/events/click-focus-anchor.html LayoutTests/fast/events/tab-focus-anchor.html Both contain a reference to a non-existing preference. The correct preference string is: WebKitTabToLinksPreferenceKey
Attachments
Patch v1
(1.59 KB, patch)
2009-09-08 14:30 PDT
,
Erik Arvidsson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Erik Arvidsson
Comment 1
2009-09-08 14:30:37 PDT
Created
attachment 39216
[details]
Patch v1
Eric Seidel (no email)
Comment 2
2009-09-08 17:38:55 PDT
Comment on
attachment 39216
[details]
Patch v1 Rejecting patch 39216 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 3
2009-09-09 09:33:35 PDT
media/video-source-error.html -> timed out Yet another flakey media test. I think I might add that one to the skipped list as yet another straw in the dam.
bug 28624
.
Eric Seidel (no email)
Comment 4
2009-09-09 09:44:52 PDT
Comment on
attachment 39216
[details]
Patch v1 Clearing flags on attachment: 39216 Committed
r48211
: <
http://trac.webkit.org/changeset/48211
>
Eric Seidel (no email)
Comment 5
2009-09-09 09:44:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug