RESOLVED FIXED28453
[CAIRO] Remove setFont indirection 
https://bugs.webkit.org/show_bug.cgi?id=28453
Summary [CAIRO] Remove setFont indirection
Jan Alonzo
Reported 2009-08-19 06:18:31 PDT
The Cairo ports (Gtk & Cairo/Win) use setFont to set a scaled font for cairo_t. I think the indirections are unnecessary as there's only one call site, which is in Font::drawGlyphs. Patch forthcoming.
Attachments
Patch v1 (6.93 KB, patch)
2009-08-19 06:23 PDT, Jan Alonzo 		eric: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-08-19 06:21:09 PDT
CC'ing Brent so he can look at it too.
Jan Alonzo
Comment 2 2009-08-19 06:23:32 PDT
Created attachment 35117 [details] Patch v1
Brent Fulgham
Comment 3 2009-08-19 09:17:21 PDT
Looks good to me. I don't see how this could cause me any problems.
Eric Seidel (no email)
Comment 4 2009-08-19 10:43:00 PDT
Comment on attachment 35117 [details] Patch v1 OK.
Eric Seidel (no email)
Comment 5 2009-08-19 10:57:13 PDT
Comment on attachment 35117 [details] Patch v1 Rejecting patch 35117 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'rebase']" exit_code: 1 cwd: None
Eric Seidel (no email)
Comment 6 2009-08-19 11:38:37 PDT
Comment on attachment 35117 [details] Patch v1 commit-queue bug.
Jan Alonzo
Comment 7 2009-08-19 13:31:26 PDT
(In reply to comment #6) > (From update of attachment 35117 [details]) > commit-queue bug. Ok, Thanks. Landed as http://trac.webkit.org/changeset/47525.
Note You need to log in before you can comment on or make changes to this bug.