Bug 28453 - [CAIRO] Remove setFont indirection
Summary: [CAIRO] Remove setFont indirection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Cairo, Gtk
Depends on:
Blocks:
 
Reported: 2009-08-19 06:18 PDT by Jan Alonzo
Modified: 2009-08-19 13:31 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (6.93 KB, patch)
2009-08-19 06:23 PDT, Jan Alonzo
eric: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2009-08-19 06:18:31 PDT
The Cairo ports (Gtk & Cairo/Win) use setFont to set a scaled font for cairo_t. I think the indirections are unnecessary as there's only one call site, which is in Font::drawGlyphs.

Patch forthcoming.
Comment 1 Jan Alonzo 2009-08-19 06:21:09 PDT
CC'ing Brent so he can look at it too.
Comment 2 Jan Alonzo 2009-08-19 06:23:32 PDT
Created attachment 35117 [details]
Patch v1
Comment 3 Brent Fulgham 2009-08-19 09:17:21 PDT
Looks good to me.  I don't see how this could cause me any problems.
Comment 4 Eric Seidel (no email) 2009-08-19 10:43:00 PDT
Comment on attachment 35117 [details]
Patch v1

OK.
Comment 5 Eric Seidel (no email) 2009-08-19 10:57:13 PDT
Comment on attachment 35117 [details]
Patch v1

Rejecting patch 35117 from commit-queue.  This patch will require manual commit.

Failed to run "['git', 'svn', 'rebase']"  exit_code: 1  cwd: None
Comment 6 Eric Seidel (no email) 2009-08-19 11:38:37 PDT
Comment on attachment 35117 [details]
Patch v1

commit-queue bug.
Comment 7 Jan Alonzo 2009-08-19 13:31:26 PDT
(In reply to comment #6)
> (From update of attachment 35117 [details])
> commit-queue bug.

Ok, Thanks. Landed as http://trac.webkit.org/changeset/47525.