Bug 28353 - yarr/RegexInterpreter.cpp crashes on ./ecma_2/RegExp/exec-002.js
Summary: yarr/RegexInterpreter.cpp crashes on ./ecma_2/RegExp/exec-002.js
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-08-16 02:19 PDT by Holger Freyther
Modified: 2009-08-16 06:16 PDT (History)
0 users

See Also:

2009-08-16 Holger Hans Peter Freyther <zecke@selfish.org> (2.15 KB, patch)
2009-08-16 02:27 PDT, Holger Freyther
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2009-08-16 02:19:54 PDT
Valgrind is showing a invalid read in popParenthesesDisjunctionContext.
Comment 1 Holger Freyther 2009-08-16 02:27:05 PDT
Created attachment 34923 [details]
2009-08-16  Holger Hans Peter Freyther  <zecke@selfish.org>

Reviewed by NOBODY (OOPS!).

Fix crash on ./ecma_2/RegExp/exec-002.js.

Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.

* yarr/RegexInterpreter.cpp:
 2 files changed, 19 insertions(+), 3 deletions(-)
Comment 2 Mark Rowe (bdash) 2009-08-16 02:43:09 PDT
Comment on attachment 34923 [details]
2009-08-16  Holger Hans Peter Freyther  <zecke@selfish.org>

Comment 3 Holger Freyther 2009-08-16 06:16:17 PDT
Landed in r47338.