WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
282525
[visionOS] Don't unnecessarily recreate PlayableViewController if one still exists
https://bugs.webkit.org/show_bug.cgi?id=282525
Summary
[visionOS] Don't unnecessarily recreate PlayableViewController if one still e...
Jean-Yves Avenard [:jya]
Reported
2024-11-03 21:39:34 PST
whenever we exit the LMK fullscreen view, in its cleanupFullscreen method, the VideoPreentationInterface calls invalidatePlayerViewController only for the WKFullscreenViewControlled configureEnvironmentPickerOfFullscreenVideoButtonView to be called shortly after which will call again videoPresentationInterface->playableViewController() which will create a new PlayableViewController. We should re-use the existing one if possible.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-11-03 21:39:52 PST
<
rdar://problem/139181732
>
Jean-Yves Avenard [:jya]
Comment 2
2025-04-07 05:55:38 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/36115
EWS
Comment 3
2025-04-08 00:46:17 PDT
Committed
293400@main
(a6c9e44beeb4): <
https://commits.webkit.org/293400@main
> Reviewed commits have been landed. Closing PR #36115 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug