Bug 28157 - Fix linker warnings about multiply-defined JSMedia symbols on Windows
Summary: Fix linker warnings about multiply-defined JSMedia symbols on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-10 11:34 PDT by Adam Roben (:aroben)
Modified: 2009-08-10 12:52 PDT (History)
0 users

See Also:


Attachments
Patch v1 (1.24 KB, patch)
2009-08-10 11:34 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Post the right patch this time. (4.87 KB, patch)
2009-08-10 11:40 PDT, Adam Roben (:aroben)
jhoneycutt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2009-08-10 11:34:22 PDT
Created attachment 34490 [details]
Patch v1

Linking WebCore on Windows generates warnings about multiply-defined symbols in JSMedia.cpp and DerivedSources.cpp. It looks like JSMedia.cpp is getting compiled twice!
Comment 1 Adam Roben (:aroben) 2009-08-10 11:40:36 PDT
Created attachment 34491 [details]
Post the right patch this time.

This fixes some compiler warnings.

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* WebCore.vcproj/WebCore.vcproj: Excluded JSMedia.cpp from the build,
as it is also listed in DerivedSources.cpp. This is what we do for the
other generated .cpp files. Also let VS reorder the file list as it
saw fit.
---
 2 files changed, 77 insertions(+), 22 deletions(-)
Comment 2 Jon Honeycutt 2009-08-10 11:42:04 PDT
Comment on attachment 34491 [details]
Post the right patch this time.

r=me
Comment 3 Adam Roben (:aroben) 2009-08-10 12:52:13 PDT
sfalken beat me to it in r46995!