WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
279219
text-emphasis-position overlapping ruby suppression broken for ruby-position: under / -webkit-ruby-position: after
https://bugs.webkit.org/show_bug.cgi?id=279219
Summary
text-emphasis-position overlapping ruby suppression broken for ruby-position:...
fantasai
Reported
2024-09-05 13:13:44 PDT
The code for checking if text-emphasis dots will overlap ruby doesn't check ruby-position, resulting in - disappearing the emphasis dots when unnecessary - overlapping dots and annotations when they're both on the under side See testcase:
https://software.hixie.ch/utilities/js/live-dom-viewer/?%3C!DOCTYPE%20html%3E%0A%3Chtml%20style%3D%22writing-mode%3A%20vertical-rl%22%3E%0A%3Cstyle%3Ep%20%7B%20text-emphasis%3A%20dot%3B%20%7D%3C%2Fstyle%3E%0A%3Cp%20style%3D%22text-emphasis-position%3A%20over%20left%22%3E%3Cruby%3Eleft%20dots%3Crt%3Eruby%3C%2Frt%3E%3C%2Fruby%3E%0A%3Cp%20style%3D%22text-emphasis-position%3A%20right%20over%22%3E%3Cruby%3Eright%20dots%3Crt%3Eruby%3C%2Frt%3E%3C%2Fruby%3E%0A%3Cp%20style%3D%22text-emphasis-position%3A%20left%20over%22%3E%3Cruby%20style%3D%22-webkit-ruby-position%3A%20after%3B%20ruby-position%3A%20under%22%3Eleft%20dots%3Crt%3Eruby%3C%2Frt%3E%3C%2Fruby%3E%0A%3Cp%20style%3D%22text-emphasis-position%3A%20over%20right%22%3E%3Cruby%20style%3D%22-webkit-ruby-position%3A%20after%3B%20ruby-position%3A%20under%22%3Eright%20dots%3Crt%3Eruby%3C%2Frt%3E%3C%2Fruby%3E%0A
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-09-05 13:14:16 PDT
<
rdar://problem/135366189
>
fantasai
Comment 2
2024-09-05 15:28:06 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/33214
EWS
Comment 3
2024-09-06 15:11:37 PDT
Committed
283282@main
(1bd2e3ab2ace): <
https://commits.webkit.org/283282@main
> Reviewed commits have been landed. Closing PR #33214 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug