Bug 27763 – PopupMenuQt lacks proper separator

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mike Fenton]

As marked by a FIXME in PopupMenuQt.cpp, the separator item used is a hardcoded string of "---".

[Mike Fenton]

Created attachment 33622 [details]
Patch to replace separator and fix include order.

[Adam Treat]

Comment on attachment 33622 [details]
Patch to replace separator and fix include order.

>          if (client()->itemIsSeparator(i)) {
> -            //FIXME: better seperator item
> -            m_popup->insertItem(i, QString::fromLatin1("---"));
> +            m_popup->insertSeparator(i);
>          } else {

Looks like you can remove the braces now from the if clause.  cpplint didn't catch it?  Also, you can go ahead and remove the #if 0 code.  If it is important somehow, that's what we have revision control systems for :)

[Mike Fenton]

Created attachment 33629 [details]
Improved Style patch

Thanks for the quick review.

This patch removes the braces for both the if and the else as well as removes the unimplemented code block.

[Mike Fenton]

Created attachment 33630 [details]
Remove extra brace from patch.

[Adam Treat]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/qt/PopupMenuQt.cpp
Committed r46483
	M	WebCore/ChangeLog
	M	WebCore/platform/qt/PopupMenuQt.cpp
r46483 = e84fb64b14709fba197a19c78e20c2076ee79ea2 (git-svn)
No changes between current HEAD and refs/remotes/git-svn
Resetting to the latest refs/remotes/git-svn
http://trac.webkit.org/changeset/46483