RESOLVED FIXED 27654
WebCore/page/Frame.cpp/h does not conform to style standards 
https://bugs.webkit.org/show_bug.cgi?id=27654
Summary WebCore/page/Frame.cpp/h does not conform to style standards
Mike Fenton
Reported 2009-07-24 07:54:39 PDT
cpplint reports a number of valid style fixes that should be made to WebCore/page/Frame.cpp/h.
Attachments
Style patch for Frame.cpp/h (44.35 KB, patch)
2009-07-24 08:13 PDT, Mike Fenton 		no flags
DetailsFormatted DiffDiff
Fixed bug # typo (44.35 KB, patch)
2009-07-24 08:17 PDT, Mike Fenton 		staikos: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike Fenton
Comment 1 2009-07-24 08:13:47 PDT
Created attachment 33449 [details] Style patch for Frame.cpp/h
Mike Fenton
Comment 2 2009-07-24 08:17:27 PDT
Created attachment 33450 [details] Fixed bug # typo
George Staikos
Comment 3 2009-07-24 09:05:05 PDT
Comment on attachment 33450 [details] Fixed bug # typo While I fundamentally disagree with this class of changes altogether, I have no reason not to r+ this.
Adam Barth
Comment 4 2009-07-25 00:35:08 PDT
I like these kinds of changes. A tidy house is a happy house. Will land.
Adam Barth
Comment 5 2009-07-25 00:47:34 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/Frame.cpp M WebCore/page/Frame.h Committed r46389 M WebCore/ChangeLog M WebCore/page/Frame.h M WebCore/page/Frame.cpp r46389 = 583e2c94fa6d32db1571218198325a659703de9b (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46389
Note You need to log in before you can comment on or make changes to this bug.