Bug 276141 – Remove `plugins()` and use `ImplementAs=embeds` in 'Document+HTML.idl'

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ahmad Saleem]

Hi Team,

We have following potential clean-up:

> https://searchfox.org/wubkat/rev/8104e1d037fe1ef5d6824f8d893b5df6c2691452/Source/WebCore/dom/Document.cpp#7243

Ref<HTMLCollection> Document::plugins()
{
    // This is an alias for embeds() required for the JS DOM bindings.
    return ensureCachedCollection<CollectionType::DocEmbeds>();
}

> https://searchfox.org/wubkat/rev/8104e1d037fe1ef5d6824f8d893b5df6c2691452/Source/WebCore/dom/Document.h#585

WEBCORE_EXPORT Ref<HTMLCollection> plugins(); // an alias for embeds() required for the JS DOM bindings.

___

By removing them and then just doing this in Document+HTML.idl:

https://searchfox.org/wubkat/rev/8104e1d037fe1ef5d6824f8d893b5df6c2691452/Source/WebCore/dom/Document+HTML.idl#48

[ImplementedAs=embeds, SameObject] readonly attribute HTMLCollection plugins;


____

Is this good clean-up? Or doable - haven't tried locally.

Thanks!

[Anne van Kesteren]

Yeah, go for it.

[Radar WebKit Bug Importer]

<rdar://problem/131407054>

[EWS]

Committed 280913@main (d4fa9f182229): <https://commits.webkit.org/280913@main>

Reviewed commits have been landed. Closing PR #30748 and removing active labels.