Bug 276080 - ReportingObserverCallbacks can leak the Document object
Summary: ReportingObserverCallbacks can leak the Document object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Reno
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-01 11:05 PDT by Ryan Reno
Modified: 2024-07-01 16:32 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Reno 2024-07-01 11:05:49 PDT 
ReportingObserverCallback is a JSC::Strong handle. So if the callback captures the document, directly or indirectly, it will leak the document object.
Comment 1 Radar WebKit Bug Importer 2024-07-01 11:06:01 PDT 
<rdar://problem/130908426>
Comment 2 Ryan Reno 2024-07-01 11:12:13 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30351
Comment 3 EWS 2024-07-01 16:32:33 PDT 
Committed 280557@main (33c1f1877fa2): <https://commits.webkit.org/280557@main>

Reviewed commits have been landed. Closing PR #30351 and removing active labels.