Bug 275519 - [ews-build] ValidateCommitMessage incorrectly fails when contributors.json is accessed from disk
Summary: [ews-build] ValidateCommitMessage incorrectly fails when contributors.json is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-06-14 16:03 PDT by Brianna Fan
Modified: 2024-07-03 11:55 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brianna Fan 2024-06-14 16:03:16 PDT 
Such as in https://ews-build.webkit.org/#/builders/19/builds/12276, accessing contributors.json from GitHub failed. However, the fallback by loading from disk behavstill caused the build to fail.
Comment 1 Radar WebKit Bug Importer 2024-06-14 16:03:29 PDT 
<rdar://problem/129880497>
Comment 2 Brianna Fan 2024-06-14 16:06:05 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29848
Comment 3 EWS 2024-07-03 11:55:16 PDT 
Committed 280634@main (18eb1e59acc2): <https://commits.webkit.org/280634@main>

Reviewed commits have been landed. Closing PR #29848 and removing active labels.