Bug 274796 – Don't consider 'fill' a presentation attribute on animation elements

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

While looking into Safari / WebKit specific failures, I noticed following failure:

Blink Commit: https://chromium-review.googlesource.com/c/chromium/src/+/2080237

WPT Test: https://wpt.fyi/results/svg/styling/presentation-attributes-special-cases.html?label=master&label=experimental&aligned=&q=safari%3Afail

> fill presentation attribute not supported on animate	
> fill presentation attribute not supported on animateMotion
> fill presentation attribute not supported on animateTransform	
> fill presentation attribute not supported on set	

We still fail: fill presentation attribute not supported on discard

___

Add following in SVGSMILElement.cpp:

bool SVGSMILElement::hasPresentationalHintsForAttribute(const QualifiedName& name) const
{
    // Don't map 'fill' to the 'fill' property for animation elements.
    if (name == SVGNames::fillAttr)
        return false;
    return SVGSMILElement::hasPresentationalHintsForAttribute(name);
}

and following in SVGSMILElement.h:

bool hasPresentationalHintsForAttribute(const QualifiedName&) const override;

___

It progresses following tests above. Just wanted to raise so we can fix it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/128896937>

[EWS]

Committed 282100@main (a0c45ccc4d6a): <https://commits.webkit.org/282100@main>

Reviewed commits have been landed. Closing PR #29192 and removing active labels.