Bug 274474 - [git-webkit] Disable commit signing by default in WebKit
Summary: [git-webkit] Disable commit signing by default in WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-21 10:15 PDT by Jonathan Bedard
Modified: 2024-05-21 11:30 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2024-05-21 10:15:21 PDT 
Since WebKit rebases and edits commit messages in merge-queue, we should explicitly disable commit signing in WebKit by default. Commit signing is actively misleading in WebKit, because of merge-queue, and may even be a considerable usability burden for contributors which need biometrics or other credentials to sign commits.
Comment 1 Radar WebKit Bug Importer 2024-05-21 10:15:33 PDT 
<rdar://problem/128477412>
Comment 2 Jonathan Bedard 2024-05-21 10:16:42 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28857
Comment 3 EWS 2024-05-21 11:30:09 PDT 
Committed 279068@main (154e6580b0c6): <https://commits.webkit.org/279068@main>

Reviewed commits have been landed. Closing PR #28857 and removing active labels.