Bug 274440 - Web Inspector: BackendDispatcher::CallbackBase should have a virtual destructor
Summary: Web Inspector: BackendDispatcher::CallbackBase should have a virtual destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Safari Technology Preview
Hardware: All All
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-20 21:17 PDT by Ryosuke Niwa
Modified: 2024-05-21 12:09 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2024-05-20 21:17:04 PDT 
BackendDispatcher::CallbackBase should have a virtual destructor since it has a bunch of subclasses.
Comment 1 Ryosuke Niwa 2024-05-20 21:19:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28828
Comment 2 EWS 2024-05-21 12:08:39 PDT 
Committed 279071@main (74af740dd35f): <https://commits.webkit.org/279071@main>

Reviewed commits have been landed. Closing PR #28828 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-05-21 12:09:13 PDT 
<rdar://problem/128484982>