RESOLVED FIXED 273789
[WPE] simde imported headers are causing lot of noise on an Aarch64 build due to undefined __ARM_NEON_FP 
https://bugs.webkit.org/show_bug.cgi?id=273789
Summary [WPE] simde imported headers are causing lot of noise on an Aarch64 build due...
Carlos Alberto Lopez Perez
Reported 2024-05-06 12:23:45 PDT
On a WebKit build targeting RPi4 with a Yocto 4.2 toolchain there are lot of warnings since 278410@main In file included from /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/simde.h:36, from /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/text/StringCommon.h:35, from /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/text/StringImpl.h:40, from /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/text/WTFString.h:28, from /home/clopez/webkit/webkit/Source/WebKit/WPEPlatform/wpe/WPEView.cpp:37: /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:73700:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 73700 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) && defined(SIMDE_ARM_NEON_FP16) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:73730:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 73730 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) && defined(SIMDE_ARM_NEON_FP16) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:73754:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 73754 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) && defined(SIMDE_ARM_NEON_FP16) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:73778:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 73778 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:73850:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 73850 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:75406:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 75406 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) && defined(SIMDE_ARM_NEON_FP16) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:75436:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 75436 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) && defined(SIMDE_ARM_NEON_FP16) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:75460:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 75460 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:75532:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 75532 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) && defined(SIMDE_ARM_NEON_FP16) | ^~~~~~~~~~~~~ /home/clopez/webkit/webkit/WebKitBuild/WPE/Release_rpi4-64bits-mesa/WTF/Headers/wtf/simde/arm/neon.h:75556:48: warning: "__ARM_NEON_FP" is not defined, evaluates to 0 [-Wundef] 75556 | #if defined(SIMDE_ARM_NEON_A32V8_NATIVE) && (__ARM_NEON_FP >= 6) [...]
Attachments
Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2024-05-06 12:29:05 PDT
Upstream simde pull-request: https://github.com/simd-everywhere/simde/pull/1179 Will backport the change to our version of the headers on another PR
Carlos Alberto Lopez Perez
Comment 2 2024-05-06 12:36:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/28194
Carlos Alberto Lopez Perez
Comment 3 2024-05-08 12:51:09 PDT
Pull request: https://github.com/WebKit/WebKit/pull/28302
EWS
Comment 4 2024-05-08 13:13:42 PDT
Committed 278521@main (84ec47698948): <https://commits.webkit.org/278521@main> Reviewed commits have been landed. Closing PR #28194 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.