Bug 273178 – [WPE] Platform: Crash on Wayland in DMA-BUF feedback handling

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Adrian Perez]

This was with an AMD GPU, open source Mesa driver, and the Labwc compositor:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  DMABufFeedback::FormatTable::FormatTable (this=0x7a56f60100e0, other=...) at ../Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:73
73                  : size(other.size)
[Current thread is 1 (Thread 0x7a575cf0a140 (LWP 1507287))]
(gdb) bt
#0  DMABufFeedback::FormatTable::FormatTable (this=0x7a56f60100e0, other=...) at ../Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:73
#1  DMABufFeedback::DMABufFeedback (this=0x7a56f60100e0, table=...) at ../Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:106
#2  std::make_unique<DMABufFeedback, DMABufFeedback::FormatTable> (__args=...) at /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.2.1/../../../../include/c++/13.2.1/bits/unique_ptr.h:1070
#3  WTF::makeUnique<DMABufFeedback, DMABufFeedback::FormatTable> (args=...) at WTF/Headers/wtf/StdLibExtras.h:602
...


There's some issue inside the main_device event callback of the DMA-BUF
feedback protocol:

#4  $_11::operator() (data=<optimized out>, device=0x5cf134b1cc80, this=<optimized out>) at ../Source/WebKit/WPEPlatform/wpe/wayland/WPEViewWayland.cpp:426
(gdb) p priv->committedDMABufFeedback 
$5 = std::unique_ptr<DMABufFeedback> = {
  get() = 0x0
}

[Adrian Perez]

Pull request: https://github.com/WebKit/WebKit/pull/27690

[EWS]

Committed 278091@main (a3f9ca459d73): <https://commits.webkit.org/278091@main>

Reviewed commits have been landed. Closing PR #27690 and removing active labels.