Bug 272637 - [WebGPU] https://playcanvas.github.io/#/graphics/post-effects fails shader compilation
Summary: [WebGPU] https://playcanvas.github.io/#/graphics/post-effects fails shader co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tadeu Zagallo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-04-13 19:57 PDT by Mike Wyrzykowski
Modified: 2024-04-17 09:10 PDT (History)
1 user (show)

See Also:

Attachments
WGSL source which reproduces the issue (11.99 KB, text/plain)
2024-04-13 19:57 PDT, Mike Wyrzykowski 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2024-04-13 19:57:04 PDT 
Created attachment 470915 [details]
WGSL source which reproduces the issue

[WebGPU] https://playcanvas.github.io/#/graphics/post-effects fails shader compilation

1 error generated while compiling the shader:
264:0: missing return at end of function

Shader source attached, I don't completely understand the error since like 264 is (unless it refers to the previous line / function):

fn scalableAmbientObscurance_vf2_vf3_vf3_(uv_4 : ptr<function, vec2<f32>>, origin_1 : ptr<function, vec3<f32>>, normal_1 : ptr<function, vec3<f32>>) -> f32 {
Comment 1 Radar WebKit Bug Importer 2024-04-13 19:57:20 PDT 
<rdar://problem/126425833>
Comment 2 Tadeu Zagallo 2024-04-15 09:45:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/27267
Comment 3 EWS 2024-04-17 09:10:11 PDT 
Committed 277618@main (79d5e4f3dd8b): <https://commits.webkit.org/277618@main>

Reviewed commits have been landed. Closing PR #27267 and removing active labels.