RESOLVED FIXED271752
[LibWebRTC] Build fails with clang-18 on Linux 
https://bugs.webkit.org/show_bug.cgi?id=271752
Summary [LibWebRTC] Build fails with clang-18 on Linux
Philippe Normand
Reported 2024-03-27 02:32:36 PDT
/var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:191:54: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-n arrowing-const-reference] 191 | {StatsReport::kStatsValueNameTotalAudioEnergy, info.total_output_energy}, | ^~~~~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:193:8: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-na rrowing-const-reference] 193 | info.total_output_duration}}; | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:247:54: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-n arrowing-const-reference] 247 | {StatsReport::kStatsValueNameTotalAudioEnergy, info.total_input_energy}, | ^~~~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:249:8: error: non-constant-expression cannot be narrowed from type 'double' to 'float' in initializer list [-Wc++11-na rrowing-const-reference] 249 | info.total_input_duration}}; | ^~~~~~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:343:51: error: non-constant-expression cannot be narrowed from type 'uint32_t' (aka 'unsigned int') to 'int' in initia lizer list [-Wc++11-narrowing-const-reference] 343 | {StatsReport::kStatsValueNameFramesDecoded, info.frames_decoded}, | ^~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:387:52: error: type 'double' cannot be narrowed to 'int' in initializer list [-Wc++11-narrowing-const-reference] 387 | {StatsReport::kStatsValueNameFrameRateInput, round(info.framerate_input)}, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:390:51: error: non-constant-expression cannot be narrowed from type 'uint32_t' (aka 'unsigned int') to 'int' in initia lizer list [-Wc++11-narrowing-const-reference] 390 | {StatsReport::kStatsValueNameNacksReceived, info.nacks_received}, | ^~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:394:51: error: non-constant-expression cannot be narrowed from type 'uint32_t' (aka 'unsigned int') to 'int' in initia lizer list [-Wc++11-narrowing-const-reference] 394 | {StatsReport::kStatsValueNameFramesEncoded, info.frames_encoded}, | ^~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:395:52: error: non-constant-expression cannot be narrowed from type 'uint32_t' (aka 'unsigned int') to 'int' in initia lizer list [-Wc++11-narrowing-const-reference] 395 | {StatsReport::kStatsValueNameHugeFramesSent, info.huge_frames_sent}, | ^~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:783:51: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initia lizer list [-Wc++11-narrowing-const-reference] 783 | {StatsReport::kStatsValueNameBytesReceived, info.recv_total_bytes}, | ^~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:784:47: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initia lizer list [-Wc++11-narrowing-const-reference] 784 | {StatsReport::kStatsValueNameBytesSent, info.sent_total_bytes}, | ^~~~~~~~~~~~~~~~~~~~~ /var/home/phil/WebKit/Source/ThirdParty/libwebrtc/Source/webrtc/pc/legacy_stats_collector.cc:785:49: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initia lizer list [-Wc++11-narrowing-const-reference] 785 | {StatsReport::kStatsValueNamePacketsSent, info.sent_total_packets}, | ^~~~~~~~~~~~~~~~~~~~~~~ and so on.
Attachments
Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2024-03-27 03:13:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/26507
EWS
Comment 2 2024-03-27 14:21:37 PDT
Committed 276753@main (753783aa83f4): <https://commits.webkit.org/276753@main> Reviewed commits have been landed. Closing PR #26507 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-03-27 14:22:13 PDT
<rdar://problem/125510007>
David Kilzer (:ddkilzer)
Comment 4 2024-05-02 08:34:16 PDT
*** Bug 273615 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.