Bug 271732 – REGRESSION (276636@main): [ macOS wk2 ] http/tests/workers/service/openwindow-from-notification-click.html is a consistent crash

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Karl Rackler]

Created attachment 470615 [details]
symbolicated-crash-log

Description:
http/tests/workers/service/openwindow-from-notification-click.html

------------- BISECTION AUDIT TRAIL -------------
276633@main --> Pass Failure
276634@main --> Pass Failure
276637@main --> Crashed 
276641@main --> Crashed 
------------- BISECTION AUDIT TRAIL END ------------- 

This leaves 276635@main - 276637@main range ( https://commits.webkit.org/compare/276635@main...276637@main ) as the possible culprit.  In that range, only 276636@main modifies the window.open process leaving it as the suspected cause.

This issue can be reproduced using the command: 
run-webkit-tests --release --no-retry --force --iterations=10 http/tests/workers/service/openwindow-from-notification-click.html

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fworkers%2Fservice%2Fopenwindow-from-notification-click.html&platform=mac

Crash Log:
Thread 0 Crashed::   Dispatch queue: com.apple.main-thread
0   com.apple.WebKit              	       0x103003e3c WTF::HashTableConstIterator<WTF::RobinHoodHashTable<WTF::String, WTF::KeyValuePair<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>>>, WTF::DefaultHash<WTF::String>, WTF::HashMap<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::MemoryCompactRobinHoodHashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::String>, WTF::MemoryCompactRobinHoodHashTableSizePolicy>, WTF::String, WTF::KeyValuePair<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>>>, WTF::DefaultHash<WTF::String>, WTF::HashMap<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::MemoryCompactRobinHoodHashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::String>> WTF::RobinHoodHashTable<WTF::String, WTF::KeyValuePair<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>>>, WTF::DefaultHash<WTF::String>, WTF::HashMap<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::MemoryCompactRobinHoodHashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::String>, WTF::MemoryCompactRobinHoodHashTableSizePolicy>::find<WTF::IdentityHashTranslator<WTF::HashMap<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::MemoryCompactRobinHoodHashTableTraits>::KeyValuePairTraits, WTF::DefaultHash<WTF::String>>, WTF::String>(WTF::String const&) const
1   com.apple.WebKit              	       0x103002a0c bool WebKit::valueForKey<bool>(WTF::HashMap<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::MemoryCompactRobinHoodHashTableTraits> const&, WTF::HashMap<WTF::String, std::__1::variant<WTF::String, bool, unsigned int, double>, WTF::DefaultHash<WTF::String>, WTF::HashTraits<WTF::String>, WTF::HashTraits<std::__1::variant<WTF::String, bool, unsigned int, double>>, WTF::MemoryCompactRobinHoodHashTableTraits> const&, WTF::String const&)
2   com.apple.WebKit              	       0x1030028d4 WebKit::WebPreferencesStore::setBoolValueForKey(WTF::String const&, bool)
3   com.apple.WebKit              	       0x1036a15a4 WebKit::WebPreferences::setThreadedScrollingEnabled(bool const&)
4   com.apple.WebKit              	       0x1031e97dc WKPreferencesSetThreadedScrollingEnabled
5   WebKitTestRunner              	       0x1024a758c WTR::PlatformWebView::PlatformWebView(OpaqueWKPageConfiguration const*, WTR::TestOptions const&)

[Radar WebKit Bug Importer]

<rdar://problem/125442890>

[Karl Rackler]

I have marked this test as a consistent crash while this issue is investigated.

[EWS]

Test gardening commit 276713@main (cff3f2dda491): <https://commits.webkit.org/276713@main>

Reviewed commits have been landed. Closing PR #26486 and removing active labels.

[Alexey Proskuryakov]

Per radar comments, this was fixed in https://commits.webkit.org/276721@main. The test is indeed no longer crashing, and is back to flakily failing.

[EWS]

Test gardening commit 276923@main (c854e7e0be45): <https://commits.webkit.org/276923@main>

Reviewed commits have been landed. Closing PR #26710 and removing active labels.