Bug 271470 - Add RELEASE_ASSERT() type check to downcast<>() on Intel
Summary: Add RELEASE_ASSERT() type check to downcast<>() on Intel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-22 08:50 PDT by Chris Dumez
Modified: 2024-03-22 09:21 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2024-03-22 08:50:55 PDT 
Add RELEASE_ASSERT() type check to downcast<>() on Intel, to match what we already do on ARM. This tested as performance neutral on the benchmarks we track.
Comment 1 Chris Dumez 2024-03-22 08:52:52 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/26320
Comment 2 EWS 2024-03-22 09:20:26 PDT 
Committed 276552@main (105163950fa3): <https://commits.webkit.org/276552@main>

Reviewed commits have been landed. Closing PR #26320 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-03-22 09:21:16 PDT 
<rdar://problem/125239185>