WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
271190
Remove unused `width()` and `height()`functions from HTMLDocument (WebKit and WebKitLegacy)
https://bugs.webkit.org/show_bug.cgi?id=271190
Summary
Remove unused `width()` and `height()`functions from HTMLDocument (WebKit and...
Ahmad Saleem
Reported
2024-03-18 15:49:13 PDT
Hi Team, It seems we dropped them in 2016 from JS exposure and we don't have them in IDL file as of today but we still have C++ code, so I think we should just do the clean-up and get rid of it. Commit (from 2016 to drop them) -
https://github.com/WebKit/WebKit/commit/aabd1dae8c07814a8c27cd98575cf473fc556eac
> Source/WebCore/html/HTMLDocument.cpp:
Delete: HTMLDocument::width() Delete: HTMLDocument::height()
> Source/WebCore/html/HTMLDocument.h:
WEBCORE_EXPORT int width(); WEBCORE_EXPORT int height();
> Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm:
- (int)width --> return NULL; - (int)height --> return NULL; ___ Just wanted to raise so we can do the clean-up. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2024-03-18 16:04:35 PDT
Removed from IDL in -
https://commits.webkit.org/179619@main
(2016)
Ahmad Saleem
Comment 2
2024-03-18 16:15:31 PDT
PR -
https://github.com/WebKit/WebKit/pull/26082
EWS
Comment 3
2024-03-21 13:12:54 PDT
Committed
276488@main
(9e4d6906a76b): <
https://commits.webkit.org/276488@main
> Reviewed commits have been landed. Closing PR #26082 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2024-03-21 13:13:15 PDT
<
rdar://problem/125188200
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug