Bug 266370 - Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h
Summary: Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-13 14:04 PST by Chris Dumez
Modified: 2023-12-13 16:49 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-12-13 14:04:28 PST 
Stop using CheckedPtr / CheckedRef in TreeScopeOrderedMap.h. Use WeakPtr / WeakRef instead to generate more actionable crashes. This tested as performance neutral on Speedometer 2 & 3.
Comment 1 Chris Dumez 2023-12-13 14:06:26 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21759
Comment 2 Radar WebKit Bug Importer 2023-12-13 14:07:19 PST 
<rdar://problem/119630913>
Comment 3 EWS 2023-12-13 16:49:30 PST 
Committed 272015@main (23026ae16e81): <https://commits.webkit.org/272015@main>

Reviewed commits have been landed. Closing PR #21759 and removing active labels.