Bug 26627 - Add download support for native webworkers
Summary: Add download support for native webworkers
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-22 15:28 PDT by David Sehr
Modified: 2009-06-24 01:08 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch to add support (17.14 KB, patch)
2009-06-22 15:42 PDT, David Sehr
no flags Details | Formatted Diff | Diff
Revised patch to hopefully fix coding style issues in UrlIsNativeWorker (17.19 KB, patch)
2009-06-22 16:23 PDT, David Sehr
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Sehr 2009-06-22 15:28:24 PDT
To enable Chromium to add support for native webworkers (implemented in NativeClient modules) we need some simple support to allow downloading of binary modules.  The default script download clamps bytes greater than 0x7f, which are needed as valid opcodes/data for x86.
Comment 1 David Sehr 2009-06-22 15:42:52 PDT
Created attachment 31681 [details]
Proposed patch to add support

I am looking for feedback as to whether this is the right approach, etc., to add download support.  Thanks in advance!
Comment 2 David Sehr 2009-06-22 16:23:00 PDT
Created attachment 31690 [details]
Revised patch to hopefully fix coding style issues in UrlIsNativeWorker
Comment 3 Sam Weinig 2009-06-22 16:50:25 PDT
I do not think support for NativeClient belongs in WebCore.  I believe this bug should be closed.  Can you explain why this should be in WebCore?
Comment 4 David Sehr 2009-06-22 16:56:53 PDT
(In reply to comment #3)
> I do not think support for NativeClient belongs in WebCore.  I believe this bug
> should be closed.  Can you explain why this should be in WebCore?
> 

We would like to add provisional support for native web workers to Chromium, and doing so requires a method for downloading a native binary.  If there are other ways to make this happen without WebCore changes, I am extremely open to suggestions.
Comment 5 Sam Weinig 2009-06-22 17:26:53 PDT
This is exactly what plugins are for.