Bug 26437 - commit-log-editor should match ambient line endings
: commit-log-editor should match ambient line endings
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-06-16 01:27 PST by
Modified: 2009-06-16 11:19 PST (History)


Attachments
patch (2.09 KB, patch)
2009-06-16 01:27 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
patch (2.10 KB, patch)
2009-06-16 01:30 PST, Adam Barth
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-06-16 01:27:27 PST
Let's see where this trail of tears leads.  Currently, the commit-log-editor dumps the ChangeLog into the commit message without regard to line endings (which might not match in these two cases).  It should be smarter and match the line endings that are already in the commit message.

Patch forthcoming.
------- Comment #1 From 2009-06-16 01:27:55 PST -------
Created an attachment (id=31341) [details]
patch
------- Comment #2 From 2009-06-16 01:30:13 PST -------
Created an attachment (id=31342) [details]
patch

slight improvement
------- Comment #3 From 2009-06-16 10:17:48 PST -------
Assigned to Adam for landing.
------- Comment #4 From 2009-06-16 11:19:54 PST -------
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/Scripts/commit-log-editor
Transmitting file data ..
Committed revision 44727.