Bug 26437 - commit-log-editor should match ambient line endings
: commit-log-editor should match ambient line endings
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Adam Barth
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-16 01:27 PDT by Adam Barth
Modified: 2009-06-16 11:19 PDT (History)
3 users (show)

See Also:


Attachments
patch (2.09 KB, patch)
2009-06-16 01:27 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
patch (2.10 KB, patch)
2009-06-16 01:30 PDT, Adam Barth
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-06-16 01:27:27 PDT
Let's see where this trail of tears leads.  Currently, the commit-log-editor dumps the ChangeLog into the commit message without regard to line endings (which might not match in these two cases).  It should be smarter and match the line endings that are already in the commit message.

Patch forthcoming.
Comment 1 Adam Barth 2009-06-16 01:27:55 PDT
Created attachment 31341 [details]
patch
Comment 2 Adam Barth 2009-06-16 01:30:13 PDT
Created attachment 31342 [details]
patch

slight improvement
Comment 3 David Levin 2009-06-16 10:17:48 PDT
Assigned to Adam for landing.
Comment 4 Adam Barth 2009-06-16 11:19:54 PDT
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/Scripts/commit-log-editor
Transmitting file data ..
Committed revision 44727.