Bug 26403 - Allow custom memory allocation control for JavaScriptCore's HashCountedSet class
Summary: Allow custom memory allocation control for JavaScriptCore's HashCountedSet class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 26313
  Show dependency tree / graph
 
Reported: 2009-06-15 04:23 PDT by Zoltan Horvath
Modified: 2009-06-22 17:50 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.27 KB, patch)
2009-06-15 04:23 PDT, Zoltan Horvath 		eric: review-
Details | Formatted Diff | Diff
updated proposed patch (2.13 KB, patch)
2009-06-16 02:14 PDT, Zoltan Horvath 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-06-15 04:23:14 PDT 
Inherits HashCountedSet class from FastAllocBase (bug #20422) because it has been instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.
Comment 1 Zoltan Horvath 2009-06-15 04:23:53 PDT 
Created attachment 31286 [details]
proposed patch
Comment 2 Darin Adler 2009-06-15 09:23:29 PDT 
Comment on attachment 31286 [details]
proposed patch

Looks fine, r=me
Comment 3 Eric Seidel (no email) 2009-06-15 17:35:10 PDT 
Comment on attachment 31286 [details]
proposed patch

Build failed while trying to land this.

Various projects (including at least JavaScriptGlue and WebCore) will need a forwarding header.
Comment 4 Eric Seidel (no email) 2009-06-15 17:35:25 PDT 
See JavaScriptGlue/ForwardingHeaders/wtf
Comment 5 Zoltan Horvath 2009-06-16 02:14:41 PDT 
Created attachment 31343 [details]
updated proposed patch

I've updated the patch, now it's working well on MAC also.
Comment 6 Brent Fulgham 2009-06-19 12:57:38 PDT 
Assigned for landing.
Comment 7 Brent Fulgham 2009-06-19 13:31:14 PDT 
Landed in http://trac.webkit.org/changeset/44865.
Comment 8 David Kilzer (:ddkilzer) 2009-06-22 17:50:23 PDT 
(In reply to comment #7)
> Landed in http://trac.webkit.org/changeset/44865.

Actually, this patch was landed in <http://trac.webkit.org/changeset/44868>.

PLEASE add bug numbers to ChangeLog entries in the future!