Bug 26113 – [Mac] break WebTextCompletionController out into its own source file

Bug 26113 - [Mac] break WebTextCompletionController out into its own source file


Summary:	[Mac] break WebTextCompletionController out into its own source file

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	WebKit Misc.
Version:	528+ (Nightly build)
Platform:	Macintosh Mac OS X 10.5

Importance:	P2 Normal
Assigned To:	Darin Adler

URL:
Keywords:

Depends on:
Blocks:	26112
	Show dependency tree / graph

Reported:	2009-05-31 23:21 PDT by Darin Adler
Modified:	2009-06-01 00:48 PDT (History)
CC List:	0 users

See Also:

Attachments
patch (975.62 KB, patch) 2009-06-01 00:41 PDT, Darin Adler	mjs: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Darin Adler 2009-05-31 23:21:26 PDT

As part of bug 26112 I broke WebCompletionController into a separate source file, but that made the patch way too big. So I'm doing that as a separate step.

Comment 1 Darin Adler 2009-06-01 00:41:28 PDT

Created attachment 30827 [details]
patch

Comment 2 Maciej Stachowiak 2009-06-01 00:44:25 PDT

Comment on attachment 30827 [details]
patch

r=me on the file split. I didn't review every line, but I assume you got it right.

Comment 3 Darin Adler 2009-06-01 00:48:31 PDT

http://trac.webkit.org/changeset/44313