Bug 259931 – Build fails when gstreamer support is disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Matt Turner]

Downstream bug: https://bugs.gentoo.org/911663

When building v2.40.5 with

         -DENABLE_VIDEO=OFF
         -DUSE_GSTREAMER_WEBRTC=OFF
         -DUSE_GSTREAMER_TRANSCODER=OFF

the build fails with:

In file included from /var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5_build/WebCore/DerivedSources/unified-sources/UnifiedSource-c57e08af-5.cpp:2:
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp: In function 'bool WebCore::MixedContentChecker::frameAndAncestorsCanDisplayInsecureContent(WebCore::Frame&, ContentType, const WTF::URL&)':
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp:92:21: error: invalid use of incomplete type 'class WebCore::FrameLoader'
   92 |         frame.loader().client().didDisplayInsecureContent();
      |         ~~~~~~~~~~~~^~
In file included from /var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp:35:
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/page/Frame.h:79:7: note: forward declaration of 'class WebCore::FrameLoader'
   79 | class FrameLoader;
      |       ^~~~~~~~~~~
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp: In function 'bool WebCore::MixedContentChecker::frameAndAncestorsCanRunInsecureContent(WebCore::Frame&, WebCore::SecurityOrigin&, const WTF::URL&, ShouldLogWarning)':
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp:112:21: error: invalid use of incomplete type 'class WebCore::FrameLoader'
  112 |         frame.loader().client().didRunInsecureContent(securityOrigin, url);
      |         ~~~~~~~~~~~~^~
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/page/Frame.h:79:7: note: forward declaration of 'class WebCore::FrameLoader'
   79 | class FrameLoader;
      |       ^~~~~~~~~~~
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp: In function 'void WebCore::MixedContentChecker::checkFormForMixedContent(WebCore::Frame&, const WTF::URL&)':
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/loader/MixedContentChecker.cpp:131:17: error: invalid use of incomplete type 'class WebCore::FrameLoader'
  131 |     frame.loader().client().didDisplayInsecureContent();
      |     ~~~~~~~~~~~~^~
/var/lib/portage/tmp/portage/net-libs/webkit-gtk-2.40.5-r600/work/webkitgtk-2.40.5/Source/WebCore/page/Frame.h:79:7: note: forward declaration of 'class WebCore::FrameLoader'
   79 | class FrameLoader;
      |       ^~~~~~~~~~~

The same configuration builds successfully with v2.40.4.

I believe one of these commits introduced the regression:

commit 169f297fcb3cb4c1f26c0c22b759044e3a448d48
Author: Ryan Reno <[e-mail]>
Date:   Wed Jun 21 10:47:16 2023 -0700

    Cherry-pick 259548.841@safari-7615-branch (74f32c21189a). https://bugs.webkit.org/show_bug.cgi?id=258303

commit 36a57b922accd6bd4a15f84f89b97fc29e713d25
Author: Ryan Reno <[e-mail]>
Date:   Tue Jun 6 14:25:44 2023 -0700

    Cherry-pick 259548.802@safari-7615-branch (bc09b6fca325). https://bugs.webkit.org/show_bug.cgi?id=257331


I've opened https://github.com/WebKit/WebKit/pull/16398 with a proposed fix.

[EWS]

merge-queue failed to commit PR to repository. To retry, remove any blocking labels and re-apply merge-queue label