Bug 256194 - [text-box-trim] Rename text-box-trim value 'normal' to 'none'
Summary: [text-box-trim] Rename text-box-trim value 'normal' to 'none'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 256183
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-01 20:46 PDT by zalan
Modified: 2023-05-04 18:12 PDT (History)
15 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2023-05-01 20:47 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2023-05-04 14:44 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-05-01 20:46:41 PDT 
ssia
Comment 1 zalan 2023-05-01 20:47:48 PDT 
Created attachment 466168 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2023-05-01 21:18:41 PDT 
Comment on attachment 466168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466168&action=review

> COMMIT_MESSAGE:1
> +[text-box-trim] Rename text-box-trim value 'normal' to 'none' to 

There's an extra "to" at the end of this line
Comment 3 Tim Nguyen (:ntim) 2023-05-03 08:01:04 PDT 
Comment on attachment 466168 [details]
Patch

Note that this will need updating as well: https://searchfox.org/wubkat/rev/6b0de0073377b856dda88c4bbf010294b36a5f58/Source/WebCore/css/CSSProperties.json#3793
Comment 4 zalan 2023-05-04 14:44:24 PDT 
Created attachment 466213 [details]
Patch
Comment 5 EWS 2023-05-04 18:11:02 PDT 
Committed 263702@main (e6837e0f21c0): <https://commits.webkit.org/263702@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466213 [details].
Comment 6 Radar WebKit Bug Importer 2023-05-04 18:12:19 PDT 
<rdar://problem/108925698>