Bug 255452 - [MSE][GStreamer] Avoid unneeded timechanged notifications
Summary: [MSE][GStreamer] Avoid unneeded timechanged notifications
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-04-14 05:56 PDT by Enrique Ocaña
Modified: 2023-04-17 02:43 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2023-04-14 05:56:52 PDT
The YouTube MSE Conformance Tests 2021[1][2] added a check to ensure that the initial warm up time of the player is less than 500 ms in accuracy tests (). While these tests pass on a fast desktop computer, they fail on a lower end device (eg: Raspberry Pi 3). This is because there's a first timeupdate event triggered as soon as the appended init segment is processed, but the processing time of the next appended data segment takes too much time, so when playback actually starts, the next timeupdate event comes later than 500ms from the first one, causing the test to fail on slow platforms.

Since the default time of the video element should be 0 from the begining and the time reported by that initial timeupdate is actually 0 (no change), that initial timeupdate event is redundant (and wasn't happening before the WebKitMediaSrc rework[3]).

[1] https://ytlr-cert.appspot.com/2021/main.html?tests=35,36,37,38&command=run
[2] https://ytlr-cert.appspot.com/2021/media/conformanceTest.js, line 886 (best displayed as https://pastebin.com/fPx1EW22)
[3] https://github.com/WebKit/WebKit/commit/9382c6ef1a5b64d1701c691c63fe84de22cf932b
Comment 1 Enrique Ocaña 2023-04-14 06:10:22 PDT
Pull request: https://github.com/WebKit/WebKit/pull/12741
Comment 2 EWS 2023-04-17 02:42:23 PDT
Committed 263019@main (c6dd1fbfea75): <https://commits.webkit.org/263019@main>

Reviewed commits have been landed. Closing PR #12741 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-04-17 02:43:18 PDT
<rdar://problem/108127936>