Bug 25373 - Popup menu has the wrong size when popped up near the edge of the screen
Summary: Popup menu has the wrong size when popped up near the edge of the screen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 24270 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-24 13:06 PDT by Johan Bilien
Modified: 2009-04-25 11:13 PDT (History)
2 users (show)

See Also:


Attachments
illustration (666 bytes, image/png)
2009-04-24 13:06 PDT, Johan Bilien
no flags Details
proposed patch (1.79 KB, patch)
2009-04-24 13:14 PDT, Johan Bilien
xan.lopez: review-
Details | Formatted Diff | Diff
the same with a ChangeLog entry (2.78 KB, patch)
2009-04-24 13:44 PDT, Johan Bilien
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bilien 2009-04-24 13:06:16 PDT
When popping up the context menu with the pointer is near the edge of the screen, the menu has the wrong size (it's not offset to not be offscreen). See the attached illustration.
Comment 1 Johan Bilien 2009-04-24 13:06:46 PDT
Created attachment 29757 [details]
illustration
Comment 2 Johan Bilien 2009-04-24 13:14:14 PDT
Created attachment 29758 [details]
proposed patch
Comment 3 Xan Lopez 2009-04-24 13:31:13 PDT
Comment on attachment 29758 [details]
proposed patch

Looks good. I need you to generate a ChangeLog with WebKitTools/Scripts/prepare-ChangeLog though, and when you upload a patch put the review flag to '?' so it appears in the review queue. Marking as r- for now, thanks for the patch!
Comment 4 Johan Bilien 2009-04-24 13:44:58 PDT
Created attachment 29760 [details]
the same with a ChangeLog entry
Comment 5 Xan Lopez 2009-04-24 13:47:45 PDT
Comment on attachment 29760 [details]
the same with a ChangeLog entry

Great. I'll commit it ASAP.
Comment 6 Xan Lopez 2009-04-24 14:18:19 PDT
Landed as r42837, thanks.
Comment 7 Enrico Tröger 2009-04-25 11:13:14 PDT
*** Bug 24270 has been marked as a duplicate of this bug. ***