Bug 253364 - Sync 'naturalWidth' and 'naturalHeight' with Spec and change from 'int' to 'unsigned'
Summary: Sync 'naturalWidth' and 'naturalHeight' with Spec and change from 'int' to '...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-03-03 17:26 PST by Ahmad Saleem
Modified: 2023-07-25 14:12 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-03-03 17:26:09 PST 
Hi Team,

Looking into HTMLImageElement.cpp, I noted that we have 'naturalWidth' and 'naturalHeight' as 'int' rather than 'unsigned' while spec says that it should be 'unsigned'.

Web-Spec: https://html.spec.whatwg.org/#the-img-element

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLImageElement.cpp#569 & https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLImageElement.cpp#577 & https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLImageElement.idl#39 etc.

Appreciate if someone can confirm whether this is still pending or we have it as intentional?

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-03-10 17:27:16 PST 
<rdar://problem/106580337>
Comment 2 EWS 2023-07-25 14:12:29 PDT 
Committed 266302@main (e7d267d296c7): <https://commits.webkit.org/266302@main>

Reviewed commits have been landed. Closing PR #16075 and removing active labels.