Bug 25262 - remove perfect hash optimization
Summary: remove perfect hash optimization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Stephanie Lewis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2009-04-16 22:18 PDT by Stephanie Lewis
Modified: 2009-05-13 05:01 PDT (History)
0 users

See Also:

Attachments
patch (6.28 KB, patch)
2009-04-16 22:21 PDT, Stephanie Lewis 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephanie Lewis 2009-04-16 22:18:50 PDT 
<rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size

Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit.  Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.
Comment 1 Stephanie Lewis 2009-04-16 22:21:29 PDT 
Created attachment 29572 [details]
patch
Comment 2 Mark Rowe (bdash) 2009-04-17 12:24:39 PDT 
Is there a reason this bug is still open?
Comment 3 Alexey Proskuryakov 2009-05-13 05:01:18 PDT 
Apparently not, see <http://trac.webkit.org/changeset/42606>.