Bug 251577 – AX: Object IDs should not be generated with AXTreeStore::generateNewID().

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Fallout from fix for https://bugs.webkit.org/show_bug.cgi?id=249480.

[Radar WebKit Bug Importer]

<rdar://problem/104956200>

[Andres Gonzalez]

Created attachment 464813 [details]
Patch

[Tyler Wilcock]

Comment on attachment 464813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464813&action=review

I'm surprised that this bug didn't cause any tests to fail. Is it testable in any way?

> Source/WebCore/accessibility/AXObjectCache.h:239
> +    AccessibilityObject* objectForID(const AXID id) const { return m_objects.get(id); }

Why not use a reference here?

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 464813 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464813&action=review
> 
> I'm surprised that this bug didn't cause any tests to fail. Is it testable
> in any way?

This is going away with the TextMarker reword, so I don't think it is worthy creating a test at this point.
> 
> > Source/WebCore/accessibility/AXObjectCache.h:239
> > +    AccessibilityObject* objectForID(const AXID id) const { return m_objects.get(id); }
> 
> Why not use a reference here?

because it can be null, i.e., the tree can be requested for an AXID that is no longer there.

[EWS]

Committed 259922@main (c11d33bb0bb2): <https://commits.webkit.org/259922@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464813 [details].