Bug 251175 - AX: Make element-reflection-arialabelledby.html and element-reflection-ariadescribedby.html async so they can pass in ITM
Summary: AX: Make element-reflection-arialabelledby.html and element-reflection-ariade...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-25 14:46 PST by Tyler Wilcock
Modified: 2023-01-27 10:55 PST (History)
10 users (show)

See Also:

Attachments
Patch (16.10 KB, patch)
2023-01-25 15:07 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (16.76 KB, patch)
2023-01-26 14:02 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (17.62 KB, patch)
2023-01-26 18:59 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (17.62 KB, patch)
2023-01-26 20:49 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-01-25 14:46:27 PST 
...
Comment 1 Radar WebKit Bug Importer 2023-01-25 14:46:39 PST 
<rdar://problem/104667374>
Comment 2 Tyler Wilcock 2023-01-25 15:07:48 PST 
Created attachment 464657 [details]
Patch
Comment 3 Andres Gonzalez 2023-01-26 06:21:22 PST 
(In reply to Tyler Wilcock from comment #2)
> Created attachment 464657 [details]
> Patch

Looks good. Why are we using 2-space indent now? Thought the WebKit coding convention including JS is 4-space indent.
Comment 4 Tyler Wilcock 2023-01-26 14:02:05 PST 
Created attachment 464673 [details]
Patch
Comment 5 Tyler Wilcock 2023-01-26 14:02:40 PST 
(In reply to Andres Gonzalez from comment #3)
> (In reply to Tyler Wilcock from comment #2)
> > Created attachment 464657 [details]
> > Patch
> 
> Looks good. Why are we using 2-space indent now? Thought the WebKit coding
> convention including JS is 4-space indent.
Fixed the indentation.
Comment 6 Tyler Wilcock 2023-01-26 18:59:32 PST 
Created attachment 464683 [details]
Patch
Comment 7 Tyler Wilcock 2023-01-26 20:49:02 PST 
Created attachment 464684 [details]
Patch
Comment 8 EWS 2023-01-27 10:55:03 PST 
Committed 259503@main (93c15846448b): <https://commits.webkit.org/259503@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464684 [details].