WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
250765
[ews-build.webkit.org] Use Twisted defer for reviewer queries
https://bugs.webkit.org/show_bug.cgi?id=250765
Summary
[ews-build.webkit.org] Use Twisted defer for reviewer queries
Jonathan Bedard
Reported
2023-01-18 09:05:23 PST
We should use Twisted's defer system to make requests listing reviewers for a specific pull-request. Note that we need to do something similar with all our GitHub requests, but piping defers through steps is a somewhat involved process, so we should do this one step at a time.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-01-18 09:07:36 PST
<
rdar://problem/104382329
>
Jonathan Bedard
Comment 2
2023-01-18 09:12:20 PST
Pull request:
https://github.com/WebKit/WebKit/pull/8769
EWS
Comment 3
2023-01-26 09:03:39 PST
Committed
259427@main
(9b7933872a4a): <
https://commits.webkit.org/259427@main
> Reviewed commits have been landed. Closing PR #8769 and removing active labels.
Jonathan Bedard
Comment 4
2023-01-30 09:06:21 PST
Re-opening for pull request
https://github.com/WebKit/WebKit/pull/9324
EWS
Comment 5
2023-01-30 11:38:09 PST
Committed
259577@main
(002460d89723): <
https://commits.webkit.org/259577@main
> Reviewed commits have been landed. Closing PR #9324 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug