Bug 25003 - Do not compare OwnPtr to 0 in CachedResource.
Summary: Do not compare OwnPtr to 0 in CachedResource.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-02 09:45 PDT by Pavel Feldman
Modified: 2009-04-02 09:56 PDT (History)
1 user (show)

See Also:

Attachments
The patch. (2.08 KB, patch)
2009-04-02 09:46 PDT, Pavel Feldman 		darin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2009-04-02 09:45:08 PDT 
Do not compare OwnPtr to 0 in CachedResource.
Comment 1 Pavel Feldman 2009-04-02 09:46:34 PDT 
Created attachment 29193 [details]
The patch.
Comment 2 Darin Adler 2009-04-02 09:48:16 PDT 
Comment on attachment 29193 [details]
The patch.

This looks wrong. Callers are supposed to compare OwnPtr to 0, and it's supposed to work properly and efficiently. Why isn't it working? That's what needs to be fixed, not call sites.
Comment 3 Dimitri Glazkov (Google) 2009-04-02 09:56:25 PDT 
:)