WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
248659
auto-functions is useless if the parser doesn't accept `auto`
https://bugs.webkit.org/show_bug.cgi?id=248659
Summary
auto-functions is useless if the parser doesn't accept `auto`
Oriol Brufau
Reported
2022-12-02 07:43:17 PST
In CSSProperties.json, properties can be defined with "auto-functions":true, this generates a style builder like static void applyValueOrphans(BuilderState& builderState, CSSValue& value) { if (downcast<CSSPrimitiveValue>(value).valueID() == CSSValueAuto) { builderState.style().setHasAutoOrphans(); return; } builderState.style().setOrphans(downcast<CSSPrimitiveValue>(value)); } However, this is useless if the parser doesn't accept `auto` as a valid keyword! So I think that an error should be reported if parser-grammar doesn't contain "auto", or something like that. Or maybe don't require that but let auto-functions automatically imply that `auto` is a valid keyword. But the current state is bad, it means that orphans:initial doesn't map to any value of its grammar, and getComputedStyle().orphans can return "auto" which is not a supported value. Both `orphans` and `widows` are affected.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-12-09 07:44:15 PST
<
rdar://problem/103180481
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug