Bug 248351 – [IFC][Text combine] Not all RenderCombineText renderers are combined

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

ssia

[alan]

Created attachment 463736 [details]
[fast-cq]Patch

[Tim Nguyen (:ntim)]

Comment on attachment 463736 [details]
[fast-cq]Patch

(fwiw, according to the spec, text should always combine, even if it doesn't fit, we should squash it to fit in 1em like FF/Chrome do (even if that makes it unreadable))

[alan]

(In reply to Tim Nguyen (:ntim) from comment #2)
> Comment on attachment 463736 [details]
> Patch
> 
> (fwiw, according to the spec, text should always combine, even if it doesn't
> fit, we should squash it to fit in 1em like FF/Chrome do (even if that makes
> it unreadable))
please file a bug. this is merely an integration patch.

[alan]

we are certainly not spec compliant here by ignoring the property when we can't find sufficient way to represent the content -not sure what the point of rendering the content unreadable, but I guess that had been debated and settled already.

[Tim Nguyen (:ntim)]

(In reply to zalan from comment #3)
> (In reply to Tim Nguyen (:ntim) from comment #2)
> > Comment on attachment 463736 [details]
> > Patch
> > 
> > (fwiw, according to the spec, text should always combine, even if it doesn't
> > fit, we should squash it to fit in 1em like FF/Chrome do (even if that makes
> > it unreadable))
> please file a bug. this is merely an integration patch.

Bug 234704 and bug 164510 have been filed for a while.

[EWS]

Committed 257035@main (0e6ff995b669): <https://commits.webkit.org/257035@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 463736 [details].

[Radar WebKit Bug Importer]

<rdar://problem/102681412>