Bug 24717 - [Qt] Many WebActions don't accurately track when they are applicable
Summary: [Qt] Many WebActions don't accurately track when they are applicable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-20 05:32 PDT by Erik L. Bunce
Modified: 2009-03-20 10:47 PDT (History)
0 users

See Also:


Attachments
Fix to make WebActions more accurately track their underlying commands (5.06 KB, patch)
2009-03-20 05:40 PDT, Erik L. Bunce
no flags Details | Formatted Diff | Diff
Fix to make WebActions more accurately track their underlying commands (5.40 KB, patch)
2009-03-20 10:11 PDT, Erik L. Bunce
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik L. Bunce 2009-03-20 05:32:54 PDT
The enablement of many WebActions doesn't accurately track when they are applicable.
 * Many commands that are implemented by using an Editor Command are tracking Editor can{EditRichly,Cut,Copy,Paste}(), which don't accurately reflect the availability of the underlying commands.
 * The setTextDirection{} actions that may be applicable to several non-rich editing context have their enablement controlled by the Editor canEditRichly().

I propose using the underlying Editor Commands concept and logic for determining when WebActions are available where applicable.
I further propose that the setTextDirection() actions should be available when canEdit() is true.

I noticed these problems while working on my QtHtmlEditor (found in https://bugs.webkit.org/attachment.cgi?id=28745).
Comment 1 Erik L. Bunce 2009-03-20 05:40:23 PDT
Created attachment 28784 [details]
Fix to make WebActions more accurately track their underlying commands
Comment 2 Erik L. Bunce 2009-03-20 10:11:39 PDT
Created attachment 28785 [details]
Fix to make WebActions more accurately track their underlying commands

Fixed WebAction documentation per Ariya's request.
Comment 3 Ariya Hidayat 2009-03-20 10:29:18 PDT
Landed in r41861.